On 2020-Jun-18, Tom Lane wrote:
> Surely it's insufficient as-is, because there is no reason to suppose
> that errno is zero at entry. You'd need to set errno = 0 first.
Oh, right.
> Also it's fairly customary in our sources to include a comment about
> this machination; so the full ritual is usually more like
Yeah, I had that in my local copy. Done like that in all the most
obvious places. But there are more places that are still wrong: I
believe every single place that calls WRITE_ERROR_EXIT is doing the
wrong thing.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services