Re: TAP tests and symlinks on Windows

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: TAP tests and symlinks on Windows
Дата
Msg-id 20200617074434.GB118592@paquier.xyz
обсуждение исходный текст
Ответ на Re: TAP tests and symlinks on Windows  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Ответы Re: TAP tests and symlinks on Windows  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Tue, Jun 16, 2020 at 07:53:26AM -0400, Andrew Dunstan wrote:
> Not one of them has it.

Argh.

> I think we'll need a dynamic test for its presence rather than just
> assuming it's there. (Use require in an eval for this).

Sure.  No problem with implementing an automatic detection.

> However, since all of them would currently fail we wouldn't actually
> have any test coverage. I could see about installing it on one or two
> animals (jacana would be a problem, it's using a very old and limited
> perl to run TAP tests.)

Okay.  This could be a problem as jacana is proving to have good
coverage AFAIK.  So it looks like we are really heading in the
direction is still skipping the test if there is no support for
symlink in the environment. At least that makes less diffs in the
patch.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: TAP tests and symlinks on Windows
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Remove dead forceSync parameter of XactLogCommitRecord()