Re: Warn when parallel restoring a custom dump without data offsets

Поиск
Список
Период
Сортировка
От David Gilman
Тема Re: Warn when parallel restoring a custom dump without data offsets
Дата
Msg-id 20200525215526.t7dqywfywxzmlpbu@dar.local
обсуждение исходный текст
Ответ на Re: Warn when parallel restoring a custom dump without data offsets  (David Gilman <dgilman@gilslotd.com>)
Ответы Re: Warn when parallel restoring a custom dump without data offsets  (David Gilman <dgilman@gilslotd.com>)
Список pgsql-hackers
The earlier patches weren't applying because I had "git config
diff.noprefix true" set globally and that was messing up the git
format-patch output.

On Mon, May 25, 2020 at 01:54:29PM -0500, David Gilman wrote:
> And I misunderstood how bad it was. I thought it was reading little
> header structs off the disk but it's actually reading the entire table
> (see _skipData). So you're quadratically rereading entire tables and
> thrashing your cache. Oops.

I changed _skipData to fseeko() instead of fread() when possible to cut
down on this thrashing further.

-- 
David Gilman  :DG<
https://gilslotd.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: factorial function/phase out postfix operators?
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: Trouble with hashagg spill I/O pattern and costing