Re: Add "-Wimplicit-fallthrough" to default flags

On 2020-May-13, Tom Lane wrote:

> Andy Fan <zhihui.fan1213@gmail.com> writes:
> >> FWIW, I got a warning for jsonpath_gram.c.
> 
> Ugh.  Confirmed here on Fedora 30 (bison 3.0.5).

Ugh.

> > I just found this just serval minutes ago.  Upgrading your bison to the
> > latest version (3.6) is ok. I'd like we have a better way to share this
> > knowledge through.  I spend ~30 minutes to troubleshooting this issue.
> 
> I fear that is going to mean that we revert this patch.

Or we can filter-out the -Wimplicit-fallthrough, or change to level 3,
for bison-emitted files.


-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services