Re: SLRU statistics
От | Tomas Vondra |
---|---|
Тема | Re: SLRU statistics |
Дата | |
Msg-id | 20200513145739.wlnbse5rw3vvscyr@development обсуждение исходный текст |
Ответ на | Re: SLRU statistics (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: SLRU statistics
|
Список | pgsql-hackers |
On Wed, May 13, 2020 at 10:26:39AM -0400, Tom Lane wrote: >Fujii Masao <masao.fujii@oss.nttdata.com> writes: >> On 2020/05/13 17:21, Tomas Vondra wrote: >>> On Wed, May 13, 2020 at 04:10:30PM +0900, Fujii Masao wrote: >>>> Also I found another minor issue; SLRUStats has not been initialized to 0 >>>> and which could update the counters unexpectedly. Attached patch fixes >>>> this issue. > >> Pushed both. Thanks! > >Why is that necessary? A static variable is defined by C to start off >as zeroes. > But is it a static variable? It's not declared as 'static' but maybe we can assume it inits to zeroes anyway? I see we do that for BgWriterStats. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления: