Re: stat() on Windows might cause error if target file is largerthan 4GB

On 2018-Sep-13, Tom Lane wrote:

> What I was vaguely imagining is that win32_port.h could #include
> whichever Windows header defines these functions and structs, and
> then do
> 
> #define stat __stat64
> 
> static inline ... __stat64(...) { return _stat64(...); }
> 
> What would need testing is whether the #define has nasty side-effects
> even if we've already included the system header.  I don't think it'd
> hurt, eg, local variables named "stat"; though people might be surprised
> when examining things in a debugger.

Did anybody test this idea?  It seems we let this problem slip unfixed,
which means Windows users cannot use pg_dump -Fd (incl. parallel dump)
when output files are large.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services