On 2020-Apr-21, Jehan-Guillaume de Rorthais wrote:
> On Tue, 21 Apr 2020 15:36:22 +0900
> Michael Paquier <michael@paquier.xyz> wrote:
> > > Also in that case, non-fast promotion is triggered. Since my patch
> > > tries to remove non-fast promotion, it's intentional to prevent them
> > > from doing that. But you think that we should not drop that because
> > > there are still some users for that?
> >
> > It would be good to ask around to folks maintaining HA solutions about
> > that change at least, as there could be a point in still letting
> > promotion to happen in this case, but switch silently to the fast
> > path.
>
> FWIW, PAF relies on pg_ctl promote. No need for non-fast promotion.
AFAICT repmgr uses 'pg_ctl promote', and has since version 3.0 (released
in mid 2015). It was only 3.3.2 (mid 2017) that supported Postgres 10,
so it seems fairly safe to assume that the removal won't be a problem.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services