Re: FETCH FIRST clause WITH TIES option

Поиск
Список
Период
Сортировка
Искать
От
Andres Freund
Тема
Re: FETCH FIRST clause WITH TIES option
Дата
Msg-id
20200408004902.u6zfzlnhj77gxmgt@alap3.anarazel.de
Ответ на
Список
Дерево обсуждения
FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Andres Freund <andres@anarazel.de>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Andrew Gierth <andrew@tao11.riddles.org.uk>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Andrew Gierth <andrew@tao11.riddles.org.uk>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Andrew Gierth <andrew@tao11.riddles.org.uk>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Andrew Gierth <andrew@tao11.riddles.org.uk>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Andrew Gierth <andrew@tao11.riddles.org.uk>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Robert Haas <robertmhaas@gmail.com>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Michael Paquier <michael@paquier.xyz>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: Re: FETCH FIRST clause WITH TIES option David Steele <david@pgmasters.net>
Re: Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Tom Lane <tgl@sss.pgh.pa.us>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Tomas Vondra <tomas.vondra@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Thomas Munro <thomas.munro@gmail.com>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Erik Rijkers <er@xs4all.nl>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera from 2ndQuadrant <alvherre@alvh.no-ip.org>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera from 2ndQuadrant <alvherre@alvh.no-ip.org>
Re: FETCH FIRST clause WITH TIES option Surafel Temesgen <surafel3000@gmail.com>
Re: FETCH FIRST clause WITH TIES option Alvaro Herrera <alvherre@2ndquadrant.com>
Re: FETCH FIRST clause WITH TIES option Tom Lane <tgl@sss.pgh.pa.us>
Hi,

On 2020-04-07 16:36:54 -0400, Alvaro Herrera wrote:
> Pushed, with some additional changes.

This triggers a new warning for me (gcc-10):
/home/andres/src/postgresql/src/backend/executor/nodeLimit.c: In function ‘ExecLimit’:
/home/andres/src/postgresql/src/backend/executor/nodeLimit.c:136:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
  136 |    if (ScanDirectionIsForward(direction))
      |       ^
/home/andres/src/postgresql/src/backend/executor/nodeLimit.c:216:3: note: here
  216 |   case LIMIT_WINDOWEND_TIES:
      |   ^~~~

I've not looked at it in any sort of detail, but it looks like it might
be a false positive, with the "fall-through" comment not being
sufficient to quiesce the compiler?

Cosmetically I would agree that falling through to the next case" a few
blocks deep inside a case: isn't the prettiest...

- Andres


В списке pgsql-hackers по дате отправления
От: Tomas Vondra
Дата:
От: Tom Lane
Дата:
FAQ