Re: BUG #16330: psql accesses null pointer in connect.c:do_connect

On 2020-Mar-31, Michael Paquier wrote:

> On Mon, Mar 30, 2020 at 12:48:51PM -0300, Alvaro Herrera wrote:
> > On 2020-Mar-30, Tom Lane wrote:
> >> It looks to me like there's a similar hazard a bit further down
> >> (line 3029):
> >> 
> >>         appendConnStrVal(&connstr, PQdb(o_conn));
> >> 
> >> I wonder if we should force reuse_previous to false if there's
> >> no o_conn, rather than fixing this stuff piecemeal.
> > 
> > That was my impression too.
> 
> Good point.  What do you think about the attached then?

Looks better :-)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services