On 2020-Mar-18, Bruce Momjian wrote:
> On Tue, Feb 25, 2020 at 09:35:52AM +0100, Antonin Houska wrote:
> > I've noticed that two variables in RelationCopyStorage() are defined in a
> > scope higher than necessary. Please see the patch.
>
> It seems cleaner to me to allocate the variables once before the loop
> starts, rather than for each loop iteration.
If we're talking about personal preference, my own is what Antonin
shows. However, since disagreement has been expressed, I think we
should only change it if the generated code turns out better.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services