On Mon, Mar 16, 2020 at 02:15:27PM +0100, Julien Rouhaud wrote:
> On Mon, Mar 16, 2020 at 09:42:39AM +0100, Julien Rouhaud wrote:
> > On Mon, Mar 16, 2020 at 01:53:35PM +0900, Masahiko Sawada wrote:
> > >
> > > In addition to comments from Michael-san, here are my comments:
>
> Thanks both for the reviews. I'm attaching a v3 with all comments addressed,
> except:
>
> > It seems to me that this test would be a good fit for
> > src/test/modules/test_misc/.
>
>
> AFAICT this is explicitly documented as tests for various extensions, and for
> now it's a core function, so I didn't move it.
>
>
> > +Run
> > + make check
> > +or
> > + make installcheck
> > Why is installcheck mentioned here?
>
>
> This is actually already used in multiple other test readme.
Sorry I forgot to update the regression tests. v4 attached.