Re: Additional size of hash table is alway zero for hash aggregates

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: Additional size of hash table is alway zero for hash aggregates
Дата
Msg-id 20200312191626.cd3i7iqawz4bcphm@alap3.anarazel.de
обсуждение исходный текст
Ответ на Additional size of hash table is alway zero for hash aggregates  (Pengzhou Tang <ptang@pivotal.io>)
Ответы Re: Additional size of hash table is alway zero for hash aggregates  (Justin Pryzby <pryzby@telsasoft.com>)
Re: Additional size of hash table is alway zero for hash aggregates  (Pengzhou Tang <ptang@pivotal.io>)
Re: Additional size of hash table is alway zero for hash aggregates  (Pengzhou Tang <ptang@pivotal.io>)
Список pgsql-hackers
Дерево обсуждения 
Hi,


On 2020-03-12 16:35:15 +0800, Pengzhou Tang wrote:
> When reading the grouping sets codes, I find that the additional size of
> the hash table for hash aggregates is always zero, this seems to be
> incorrect to me, attached a patch to fix it, please help to check.

Indeed, that's incorrect. Causes the number of buckets for the hashtable
to be set higher - the size is just used for that.  I'm a bit wary of
changing this in the stable branches - could cause performance changes?

Greetings,

Andres Freund

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: The flinfo->fn_extra question, from me this time.
Следующее
От: Andres Freund
Дата:
Сообщение: Re: [PATCH] Skip llvm bytecode generation if LLVM is missing