On Tue, Mar 10, 2020 at 12:39:53PM -0300, Alvaro Herrera wrote:
> Another option is to return the command as a palloc'ed string (per
> psprintf), instead of using a caller-stack-allocated variable. Passing
> the buffer len is widely used, but more error prone (and I think getting
> this one wrong might be more catastrophic than a mistake elsewhere.)
> This is not a performance-critical path enough that we *need* the
> optimization that avoids the palloc is important. (Failure can be
> reported by returning NULL.)
That's a better approach here.
> Also, I think the function comment could stand some more detailing.
What kind of additional information would you like to add on top of
what the updated version attached does?
> Also, I think Msvcbuild.pm could follow Makefile's ideas of one line per
> file. Maybe no need to fix all of that in this patch, but let's start
> by adding the new file it its own line rather than reflowing two
> adjacent lines (oh wait ... does perltidy put it that way? if so,
> nevermind.)
Good idea. It happens that perltidy does not care about that, but I
would rather keep that stuff for a separate patch/thread.
--
Michael