On 2020-Feb-07, Jehan-Guillaume de Rorthais wrote:
> Maybe I would just add:
>
> /*
> * If this constraint has a parent constraint which we have not seen
> * yet, keep track of it for the second loop, below.
> + * Tracking parent constraint allows to climb up to the top-level
> + * level constraint and look for all possible relation referencing
> + * the partioned table.
> */
LGTM.
BTW I was thinking that perhaps it would make sense to go up all levels
at once when we see a "parented" constraint; this would avoid having to
restart several times when there's N-levels partitioning. It might be
an issue if pg_constraint is large, because, you see, there's a seqscan
there! (Maybe now's the time to add an index to confrelid, but of
course only in master). This probably doesn't matter much normally
because nobody uses that many partition levels ...
> This is out of the scope of this bug fix in my humble opinion. This would be a
> whole new feature, even if it could be done without a new syntax.
Sure.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services