Re: BUG #16242: convert_tuple_* not handling missing values correctly

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: BUG #16242: convert_tuple_* not handling missing values correctly
Дата
Msg-id 20200206054846.GI23913@paquier.xyz
обсуждение исходный текст
Ответ на Re: BUG #16242: convert_tuple_* not handling missing values correctly  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Список pgsql-bugs
Дерево обсуждения 
On Wed, Feb 05, 2020 at 07:22:20PM +0000, Andrew Gierth wrote:
> I'll commit this (with fixed comments) unless anyone can immediately
> think of any reason not to...

The patch you have written looks right to me on HEAD and the
back-branches.  Now, you have added only a test that stresses
atthasmissing in convert_tuples_by_name_map_if_req(), but you are not
covering the paths from convert_tuples_by_position().  Shouldn't we
have a second test for that part as well?
--
Michael
Вложения

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Jehan-Guillaume de Rorthais
Дата:
Сообщение: Another FK violation when referencing a multi-level partitionedtable
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Another FK violation when referencing a multi-level partitionedtable