Some incorrect option sizes for PQconninfoOption in libpq

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Some incorrect option sizes for PQconninfoOption in libpq
Дата
Msg-id 20200128053633.GD1552@paquier.xyz
обсуждение исходный текст
Ответы Re: Some incorrect option sizes for PQconninfoOption in libpq
Список pgsql-hackers
Hi all,

I was reviewing the libpq code for the recent SSL protocol patch, and
noticed two mistakes with dispsize for the following parameters:
- channel_binding should be at 8, the largest value being "require".
- gssencmode should be at 8.

In those cases the zero-terminator was forgotten in the count.  A
similar mistake was done in the past for sslmode that was fixed by
f4051e36.  It is unlikely that dispsize is being used, but we cannot
break that on compatibility grounds, and the current numbers are
incorrect so let's fix it.

Thoughts?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Thomas Munro
Дата:
Сообщение: Re: Should we add xid_current() or a int8->xid cast?
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions