Re: remove some STATUS_* symbols

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: remove some STATUS_* symbols
Дата
Msg-id 20200106063159.GQ3598@paquier.xyz
обсуждение исходный текст
Ответ на remove some STATUS_* symbols  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Ответы Re: remove some STATUS_* symbols
Список pgsql-hackers
On Sun, Dec 29, 2019 at 11:33:34AM +0100, Peter Eisentraut wrote:
> Attached are two patches to remove these two symbols.  STATUS_FOUND can be
> replaced by a simple bool.  STATUS_WAITING is replaced by a separate enum.

Patch 0001 looks good to me, but I got to wonder why the check after
waitMask in LockAcquireExtended() is not done directly in
LockCheckConflicts().

Regarding patch 0002, I am not sure that the addition of
ProcWaitStatus brings much though in terms of code readability.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Masahiko Sawada
Дата:
Сообщение: Re: parallel vacuum options/syntax
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Add pg_file_sync() to adminpack