Re: automating pg_config.h.win32 maintenance

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: automating pg_config.h.win32 maintenance
Дата
Msg-id 20191213134416.GB103520@paquier.xyz
обсуждение исходный текст
Ответ на Re: automating pg_config.h.win32 maintenance  (Heikki Linnakangas <hlinnaka@iki.fi>)
Ответы Re: automating pg_config.h.win32 maintenance  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: automating pg_config.h.win32 maintenance  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Список pgsql-hackers
On Fri, Dec 13, 2019 at 03:14:08PM +0200, Heikki Linnakangas wrote:
> On 13/12/2019 14:51, Peter Eisentraut wrote:
>> Keeping pg_config.h.win32 up to date with pg_config.h.in is a gratuitous
>> annoyance.
>
> Hear hear!

Youpi.

> I don't think this @simple_defines is really any better than listing all the
> options directly with "$define{HAVE_ATOMICS} = 1". And some simple defines
> are already listed like that, e.g. HAVE_DECL_STRNLEN above that list.

Agreed.

It would be nice to put a comment close to FLEXIBLE_ARRAY_MEMBER,
where you use "/* */" as a way to emulate an empty value which is
still defined.  Or would it be cleaner to just use an empty string?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: error context for vacuum to include block number
Следующее
От: Tom Lane
Дата:
Сообщение: Re: automating pg_config.h.win32 maintenance