Re: pglz performance
От | Tomas Vondra |
---|---|
Тема | Re: pglz performance |
Дата | |
Msg-id | 20191128224356.4oca4lijnpnqctqa@development обсуждение исходный текст |
Ответ на | Re: pglz performance (Andrey Borodin <x4mmm@yandex-team.ru>) |
Ответы |
Re: pglz performance
|
Список | pgsql-hackers |
On Wed, Nov 27, 2019 at 11:27:49PM +0500, Andrey Borodin wrote: > > >> 27 нояб. 2019 г., в 20:28, Tomas Vondra <tomas.vondra@2ndquadrant.com> написал(а): >> >>>> >>>> 6) I'm pretty sure the comment in the 'while (off < len)' branch will be >>>> badly mangled by pgindent. >>> >>> I think I can just write it without line limit and then run pgindent. >>> Will try to do it this evening. Also, I will try to write more about >>> memmove. >Well, yes, I could not make pgindent format some parts of that comment, gave up and left only simple text. >>> >>>> >>>> 7) The last change moving "copy" to the next line seems unnecessary. >>> >>> Oh, looks like I had been rewording this comment, and eventually came >>> to the same text..Yes, this change is absolutely unnecessary. >>> >>> Thanks! >>> >> >> Good. I'll wait for an updated version of the patch and then try to get >> it pushed by the end of the CF. > OK, pushed, with some minor cosmetic tweaks on the comments (essentially using the formatting trick pointed out by Alvaro), and removing one unnecessary change in pglz_maximum_compressed_size. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления: