On 2019-Sep-26, Jeff Janes wrote:
> On Wed, Sep 11, 2019 at 3:52 PM Alvaro Herrera <alvherre@2ndquadrant.com>
> wrote:
>
> > Reading over this code, I noticed that the detection of the catch-up
> > state ends up being duplicate code, so I would rework that function as
> > in the attached patch.
> >
> > The naming of those flags (got_SIGUSR2, got_STOPPING) is terrible, but
> > I'm not going to change that in a backpatchable bug fix.
>
> Hi Alvaro, does this count as a review?
Well, I'm already a second pair of eyes for Craig's code, so I think it
does :-) I would have liked confirmation from Craig that my change
looks okay to him too, but maybe we'll have to go without that.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services