On 2019-Jul-30, Ashwin Agrawal wrote:
> On Tue, Jul 16, 2019 at 10:22 AM Andres Freund <andres@anarazel.de> wrote:
> > Looks good to me. Planning to apply this unless somebody wants to argue
> > against it soon?
>
> Andres, I didn't yet register this for next commitfest. If its going in
> soon anyways will not do it otherwise let me know and I will add it to the
> list.
Sounds OK ... except that Travis points out that Ashwin forgot to patch contrib:
make[4]: Entering directory '/home/travis/build/postgresql-cfbot/postgresql/contrib/amcheck'
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute-Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -Wall
-Werror-fPIC -I. -I. -I../../src/include -I/usr/include/x86_64-linux-gnu -D_GNU_SOURCE -c -o verify_nbtree.o
verify_nbtree.c
verify_nbtree.c: In function ‘bt_check_every_level’:
verify_nbtree.c:614:11: error: passing argument 6 of ‘table_index_build_scan’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
bt_tuple_present_callback, (void *) state, scan);
^
In file included from verify_nbtree.c:29:0:
../../src/include/access/tableam.h:1499:1: note: expected ‘IndexBuildCallback {aka void (*)(struct RelationData *,
structItemPointerData *, long unsigned int *, _Bool *, _Bool, void *)}’ but argument is of type ‘void (*)(struct
RelationData*, HeapTupleData *, Datum *, _Bool *, _Bool, void *) {aka void (*)(struct RelationData *, struct
HeapTupleData*, long unsigned int *, _Bool *, _Bool, void *)}’
table_index_build_scan(Relation table_rel,
^
cc1: all warnings being treated as errors
<builtin>: recipe for target 'verify_nbtree.o' failed
make[4]: *** [verify_nbtree.o] Error 1
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services