Re: pg_upgrade check fails on Solaris 10

On 2019-Sep-17, Marina Polyakova wrote:

> Hello, hackers!
> 
> We got an error for pg_upgrade check on the branch REL_11_STABLE (commit
> 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC the
> argument to the sed command is not enclosed in quotation marks (see [1]):

Hmm, I'm surprised it has taken this long to detect the problem.

> Attached diff.patch fixes the problem.

I have pushed it to all branches that have src/bin/pg_upgrade (namely,
9.5 onwards), thanks.  I hope this won't make the msys/mingw machines
angry ;-)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services