Re: logical decoding : exceeded maxAllocatedDescs for .spill files
От | Tomas Vondra |
---|---|
Тема | Re: logical decoding : exceeded maxAllocatedDescs for .spill files |
Дата | |
Msg-id | 20190913145734.mpesqes7yi6gtgau@development обсуждение исходный текст |
Ответ на | Re: logical decoding : exceeded maxAllocatedDescs for .spill files (Andres Freund <andres@anarazel.de>) |
Список | pgsql-hackers |
On Thu, Sep 12, 2019 at 11:34:01AM -0700, Andres Freund wrote: >Hi, > >On 2019-09-12 09:57:55 -0300, Alvaro Herrera wrote: >> On 2019-Sep-12, Tomas Vondra wrote: >> >> > On Wed, Sep 11, 2019 at 09:51:40AM -0300, Alvaro Herrera from 2ndQuadrant wrote: >> > > On 2019-Sep-11, Amit Khandekar wrote: >> >> > > I think doing this all the time would make restore very slow -- there's a >> > > reason we keep the files open, after all. >> > >> > How much slower? It certainly will have a hit, but maybe it's negligible >> > compared to all the other stuff happening in this code? > >I'd expect it to be significant. > > >> > As a sidenote - in the other thread about streaming, one of the patches >> > does change how we log subxact assignments. In the end, this allows using >> > just a single file for the top-level transaction, instead of having one >> > file per subxact. That would also solve this. > >Uhm, how is rollback to savepoint going to be handled in that case? I >don't think it's great to just retain space for all rolled back >subtransactions. > The code can just do ftruncate() to the position of the subtransaction. That's what the patch [1] does. [1] https://commitfest.postgresql.org/24/1927/ regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления: