On 2019-Sep-13, Fujii Masao wrote:
> On Mon, Sep 9, 2019 at 3:52 PM Jamison, Kirk <k.jamison@jp.fujitsu.com> wrote:
> > > Please add a preliminary patch that removes the function. Dead code is good,
> > > as long as it is gone. We can get it pushed ahead of the rest of this.
> >
> > Alright. I've attached a separate patch removing the smgrdounlinkfork.
>
> Per the past discussion, some people want to keep this "dead" function
> for some reasons. So, in my opinion, it's better to just enclose the function
> with #if NOT_USED and #endif, to keep the function itself as it is, and then
> to start new discussion on hackers about the removal of that separatedly
> from this patch.
I searched for anybody requesting to keep the function. I couldn't find
anything. Tom said in 2012:
https://www.postgresql.org/message-id/1471.1339106082@sss.pgh.pa.us
> As committed, the smgrdounlinkfork case is actually dead code; it's
> never called from anywhere. I left it in place just in case we want
> it someday.
but if no use has appeared in 7 years, I say it's time to kill it.
In absence of objections, I'll commit a patch to remove it later today.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services