On Wed, Sep 11, 2019 at 11:22:45PM +0800, Masahiko Sawada wrote:
> Hmm it will be more consistent with other functions but I think we
> would need to increase the pageinspect version to 1.8 and need the new
> sql file to rename the function name. And it will be for PG12, not
> PG13. If we have to do it someday I think it's better to do it in PG12
> that the table AM has been introduced to. Anyway I've attached
> separate patch for it.
Like Alvaro, I would discard this one for now.
> I've attached the updated patch that incorporated all comments. I kept
> the function as superuser-restricted.
But not this one. So committed. I have gone through the patch and
adjusted a couple of things in the tests, the docs with weird
formulations and an example leading mainly to NULLs returned when
scanning the first page of pg_class. The tests needed some
improvements to gain in clarity (no need for unnest with 2 elements,
added tests for all the combined flags, etc.). The patch was not
indented either but this is no big deal.
I hope I forgot to credit nobody in the commit message. If that's the
case, you are the winner of a drink of your choice the next time we
meet.
--
Michael