Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay
Дата
Msg-id 20190911195233.GA3904@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Ответы Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay  (Jeff Janes <jeff.janes@gmail.com>)
Список pgsql-hackers
On 2019-Sep-03, Alvaro Herrera wrote:

> On 2019-Jul-25, Craig Ringer wrote:
> 
> > Patch attached.
> 
> Here's a non-broken version of this patch.  I have not done anything
> other than reflowing the new comment.

Reading over this code, I noticed that the detection of the catch-up
state ends up being duplicate code, so I would rework that function as
in the attached patch.

The naming of those flags (got_SIGUSR2, got_STOPPING) is terrible, but
I'm not going to change that in a backpatchable bug fix.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Nino Floris
Дата:
Сообщение: Re: [PATCH] ltree, lquery, and ltxtquery binary protocol support
Следующее
От: Fabien COELHO
Дата:
Сообщение: Re: psql - improve test coverage from 41% to 88%