On 2019-Aug-26, Tom Lane wrote:
> James Coleman <jtc331@gmail.com> writes:
> I think the comment is fine as-is. Perhaps the code would be clearer
> though, if we merged those two asserts into one?
>
> /* Assert we're called before loading any tuples */
> Assert(state->status == TSS_INITIAL &&
> state->memtupcount == 0);
Makes sense to me. James, do you want to submit a new patch?
> I'm not totally sure about the usefulness/relevance of the two
> assertions following these, but they could likely do with their
> own comment(s), because this one surely isn't covering them.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services