Re: Plug-in common/logging.h with vacuumlo and oid2name

On Wed, Sep 04, 2019 at 10:17:57AM +0200, Peter Eisentraut wrote:
> On 2019-08-20 03:28, Michael Paquier wrote:
> > +                    pg_log_error("\nfailed to remove lo %u: %s", lo,
> > +                                 PQerrorMessage(conn));
>
> This newline should be removed.

Thanks, missed that.

> progname can probably be made into a local variable now.

Can it?  vacuumlo() still uses the progname from _param for the
connection string.

> Do we need set_pglocale_pgservice() calls here if we're not doing NLS?
> Does the logging stuff require it?  I'm not sure.

The logging part does not require it, but this can be used for
PGSYSCONFDIR, no?
--
Michael