On Mon, Aug 19, 2019 at 05:12:12PM +0300, Liudmila Mantrova wrote:
> Please consider the attached patches that fix some documentation
> inconsistencies in REL_12_STABLE branch. The first one contains fixes of
> typos and tagging issues that were discovered during new content
> translation. The other is a back-patch of fixes already accepted in master
> after REL_12_STABLE has been created (originally reported by Alexander
> Lakhin in "Fix typos and inconsistencies for HEAD" series).
Most of the stuff in v12-doc-fixes.patch looks pretty good. I don't
agree with some of the changes in libpq.sgml, as firstterm is used to
outline the different modes of the error verbosity API. Using
firstterm is also more consistent with ErrorContextVisibility. You
are right though that a markup for the default mode goes missing. I
have tweaked a couple of other things, and committed that part to HEAD
and REL_12_STABLE.
Now, for the second patch... First thanks for helping me with my
laziness and gather all the changes which have been done in the docs
on HEAD (Alexander has done an awesome lot of work recently and going
after each doc change was too much for me). Some of the issues are
much older than 12, so I have committed them separately with the
portions that are affected.
--
Michael