Re: Unused header file inclusion

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Unused header file inclusion
Дата
Msg-id 20190807210008.GA18170@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: Unused header file inclusion  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Unused header file inclusion  (Thomas Munro <thomas.munro@gmail.com>)
Список pgsql-hackers
On 2019-Aug-05, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Then there's the <limits.h> removal, which is in tuplesort.c because of
> > INT_MAX as added by commit d26559dbf356 and still present ...
> 
> One has to be especially wary of removing system-header inclusions;
> the fact that they don't seem to be needed on your own machine doesn't
> prove they aren't needed elsewhere.

As far as I can see, this line was just carried over from tuplestore.c,
but that file uses INT_MAX and this one doesn't use any of those macros
as far as I can tell.

I pushed this change and hereby consider this to be over.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Duplicated LSN in ReorderBuffer
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Grouping isolationtester tests in the schedule