Re: Refactoring code stripping trailing \n and \r from strings

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Refactoring code stripping trailing \n and \r from strings
Дата
Msg-id 20190807011036.GA2345@paquier.xyz
обсуждение исходный текст
Ответ на Re: Refactoring code stripping trailing \n and \r from strings  (Bruce Momjian <bruce@momjian.us>)
Ответы Re: Refactoring code stripping trailing \n and \r from strings  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Tue, Aug 06, 2019 at 03:10:33PM -0400, Bruce Momjian wrote:
> On Thu, Aug  1, 2019 at 12:18:20PM +0900, Michael Paquier wrote:
>> b654714 has reworked the way we handle removal of CLRF for several
>> code paths, and has repeated the same code patterns to do that in 8
>> different places.  Could it make sense to refactor things as per the
>> attached with a new routine in common/string.c?
>
> Yes, I think this is a good idea.

Thanks for the review, Bruce!  Tom, do you have any objections?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Thomas Munro
Дата:
Сообщение: Re: stress test for parallel workers
Следующее
От: Amit Langote
Дата:
Сообщение: Re: partition routing layering in nodeModifyTable.c