On 2019-Aug-05, Alvaro Herrera wrote:
> So we have three locations for that test; one is where it currently is,
> which handles a small subset of the cases. The other is where Amit
> first proposed putting it, which handles some additional cases; and the
> third one is where your latest patch puts it, which seems to handle all
> cases. Isn't that what Amit is saying? If that's correct (and that's
> what I want to imply with the comment changes I proposed), then we
> should just accept that version of the patch.
... actually, there's a fourth possible location, which is outside the
per-partitioning-attribute loop. Nothing in the moved block is to be
done per attribute, so it'd be wasted work AFAICS. I propose the
attached.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services