Re: minor fixes after pgindent prototype fixes

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: minor fixes after pgindent prototype fixes
Дата
Msg-id 20190729184712.GA19415@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: minor fixes after pgindent prototype fixes  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 2019-Jul-28, Tom Lane wrote:

> Andres Freund <andres@anarazel.de> writes:
> > a few prototypes look odd. It appears to be cases where previously the
> > odd indentation was put to some use, by indenting parameters less:
> > ...
> > but now that looks odd:
> > extern void DefineCustomBoolVariable(
> >                                      const char *name,
> >                                      const char *short_desc,
> 
> > Unless somebody protests I'm going to remove the now pretty useless
> > looking newline in the cases I can find.
> 
> +1.  I think Alvaro was muttering something about doing this,
> but you beat him to it.

No, this is a different issue ...  I was talking about function *calls*
ending in parens, and it changed because of the previous round of
pgindent changes, not the last one.  The number of affected places was a
lot larger than the patch Andres posted.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Proposal for Signal Detection Refactoring
Следующее
От: Robert Haas
Дата:
Сообщение: Re: POC: Cleaning up orphaned files using undo logs