On 2019-Jul-22, Julien Rouhaud wrote:
> On Mon, Jul 22, 2019 at 6:11 AM Michael Paquier <michael@paquier.xyz> wrote:
> > simple_string_list_append(&tables, optarg);
> > + tbl_count++;
> > break;
> > The number of items in a simple list is not counted, and vacuumdb does
> > the same thing to count objects. What do you think about extending
> > simple lists to track the number of items stored?
>
> I considered this, but it would require to adapt all code that declare
> SimpleStringList stack variable (vacuumdb.c, clusterdb.c,
> createuser.c, pg_dumpall.c and pg_dump.c), so it looked like too much
> trouble to avoid 2 local variables here and 1 in vacuumdb.c. I don't
> have a strong opinion here, so I can go for it if you prefer.
Can we use List for this instead?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services