Re: Contribution to Perldoc for TestLib module in Postgres

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Contribution to Perldoc for TestLib module in Postgres
Дата
Msg-id 20190710073316.GD5042@paquier.xyz
обсуждение исходный текст
Ответ на Re: Contribution to Perldoc for TestLib module in Postgres  (Daniel Gustafsson <daniel@yesql.se>)
Список pgsql-hackers
On Tue, Jul 09, 2019 at 03:16:01PM +0200, Daniel Gustafsson wrote:
> The v2 patch is somewhat confused as it has Windows carriage returns rather
> than newlines, so it replaces the entire file making the diff hard to read.  It
> also includes a copy of TestLib and the v1 patch and has a lot of whitespace
> noise.

Nobody can provide a clear review if the files are just fully
rewritten even based on a read of the patch.  Perhaps you are working
on Windows and forgot to configure core.autocrlf with "git config".
That could make your life easier.

I have switched the patch as "waiting on author" for now.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)
Следующее
От: Amit Langote
Дата:
Сообщение: Re: Excessive memory usage in multi-statement queries w/ partitioning