It seems strange to have relation_reloptions which abstracts away the
need to know which function to call for each relkind, and separately
have a bunch of places that call the specific relkind. Why not just
call the specific function directly? It doesn't seem that we're gaining
any abstraction ... maybe it'd be better to just remove
relation_reloptions entirely. Or maybe we need to make it do a better
job so that other places don't have to call the specific functions at
all.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services