Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock
Дата
Msg-id 20190614153736.GA21626@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-committers
On 2019-Jun-14, Tom Lane wrote:

> I wrote:
> >> Hm, I don't get that warning.  Does this patch silence it, please?
> 
> > Uh, no patch attached?  But initializing the variable where it's
> > declared would certainly silence it.
> 
> BTW, after looking around a bit I wonder if this complaint isn't
> exposing an actual logic bug.  Shouldn't skip_tuple_lock have
> a lifetime similar to first_time?

I think you're right.  I should come up with a test case that exercises
that case.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-committers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: Silence compiler warning
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: First-draft release notes for 11.4.