Re: BUG #15833: defining a comment on a domain constraint fails withwrong OID

On Mon, Jun 10, 2019 at 08:55:27AM -0400, Alvaro Herrera wrote:
> -1 on this approach.  Having this ownercheck function return the owning
> object ID seems way too strange.  I'd rather not have the new ownercheck
> function, and instead do a syscache search to obtain the type OID in
> check_object_ownership, then do pg_type_ownercheck.  I'm not even sure
> that pg_domain_constraint_ownercheck makes a lot of sense in itself,
> since it's never the constraint that requires an owner check.

I can see your point, yes perhaps I overdid it.  What do you think
about the attached instead?  This moves the syscache lookup directly
into check_object_ownership() as you suggest.
--
Michael