Re: Custom table AMs need to include heapam.h because ofBulkInsertState

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: Custom table AMs need to include heapam.h because ofBulkInsertState
Дата
Msg-id
20190601195505.GH1905@paquier.xyz
Ответ на
Список
Дерево обсуждения
Custom table AMs need to include heapam.h because of BulkInsertState Michael Paquier <michael@paquier.xyz>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Andres Freund <andres@anarazel.de>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Michael Paquier <michael@paquier.xyz>
Re: Custom table AMs need to include heapam.h because of BulkInsertState Robert Haas <robertmhaas@gmail.com>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Andres Freund <andres@anarazel.de>
Re: Custom table AMs need to include heapam.h because of BulkInsertState Robert Haas <robertmhaas@gmail.com>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because of BulkInsertState Andres Freund <andres@anarazel.de>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Michael Paquier <michael@paquier.xyz>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Michael Paquier <michael@paquier.xyz>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Andres Freund <andres@anarazel.de>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Andres Freund <andres@anarazel.de>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Andres Freund <andres@anarazel.de>
Re: Custom table AMs need to include heapam.h because of BulkInsertState David Rowley <david.rowley@2ndquadrant.com>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Michael Paquier <michael@paquier.xyz>
Re: Custom table AMs need to include heapam.h because of BulkInsertState Robert Haas <robertmhaas@gmail.com>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Michael Paquier <michael@paquier.xyz>
Re: Custom table AMs need to include heapam.h because of BulkInsertState Robert Haas <robertmhaas@gmail.com>
Re: Custom table AMs need to include heapam.h because ofBulkInsertState Michael Paquier <michael@paquier.xyz>
On Sat, Jun 01, 2019 at 12:19:43PM -0700, Andres Freund wrote:
> Yea, I think we should do that at some point. But I'm not sure this is
> the right design. Bulk insert probably needs to rather be something
> that's allocated inside the AM.

Yeah, actually you may be right that I am not taking the correct path
here.  At quick glance it looks that there is a strong relationship
between the finish_bulk_insert callback and the bistate free already,
so we could do much better than moving the code around.  Perhaps we
could just have a TODO?  As one of the likely-doable items.
--
Michael
В списке pgsql-hackers по дате отправления
От: Andres Freund
Дата:
От: Michael Meskes
Дата:
Сообщение: Re: coverage additions
FAQ