On Fri, May 17, 2019 at 01:24:43PM -0700, Andres Freund wrote:
> I don't think a windows-only patch is the same thing as a feature, one
> that makes debugging easier to boot, that's applicable to all
> platforms.
We are discussing here a set of problems which breaks the logging
collector to work on Windows, requiring mostly a Windows patch. And I
am not much willing to mess up with the area of shared memory handling
on Windows a couple of days before a beta.
>> diff --git a/src/tools/msvc/config_default.pl b/src/tools/msvc/config_default.pl
>> @@ -17,7 +17,7 @@ our $config = {
>> gss => undef, # --with-gssapi=<path>
>> icu => undef, # --with-icu=<path>
>> nls => undef, # --enable-nls=<path>
>> - tap_tests => undef, # --enable-tap-tests
>> + tap_tests => 1, # --enable-tap-tests
>> tcl => undef, # --with-tcl=<path>
>> perl => undef, # --with-perl
>> python => undef, # --with-python=<path>
>
> Hm? Is this to coerce cfbot?
This is part of the patch only because it has proved to be useful for
testing with MSVC on my VMs. I am not suggesting to add that in this
patch if this gets merged into HEAD. It is actually a good idea to
enforce that sometimes for the cfbot.. I'll remember your suggestion
for future patches.
--
Michael