Re: error messages in extended statistics
От | Tomas Vondra |
---|---|
Тема | Re: error messages in extended statistics |
Дата | |
Msg-id | 20190503194217.53bub7jqml43kml4@development обсуждение исходный текст |
Ответ на | Re: error messages in extended statistics (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: error messages in extended statistics
|
Список | pgsql-hackers |
On Fri, May 03, 2019 at 12:21:36PM -0400, Tom Lane wrote: >Alvaro Herrera <alvherre@2ndquadrant.com> writes: >> Error reporting in extended statistics is inconsistent -- many messages >> that are ereport() in mvdistinct.c are elog() in the other modules. >> ... >> I think this should be cleaned up, while at the same time not giving too >> much hassle for translators; for example, this message >> dependencies.c: elog(ERROR, "invalid MVDependencies size %zd (expected at least %zd)", >> should not only be turned into an ereport(), but also the MVDependencies >> part turned into a %s. (Alternatively, we could decide I was wrong and >> turn them all back into elogs, but I obviously vote against that.) > >FWIW, I'd vote the other way: that seems like a clear "internal error", >so making translators deal with it is just make-work. It should be an >elog. If there's a reasonably plausible way for a user to trigger an >error condition, then yes ereport, but if we're reporting situations >that couldn't happen without a server bug then elog seems fine. > Yeah, I agree. Most of (peshaps all) those errors are internal errors, and thus should be elog. I'll take care of clening this up a bit. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления: