Re: pg_upgrade --clone error checking

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: pg_upgrade --clone error checking
Дата
Msg-id 20190502162849.GA2314@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: pg_upgrade --clone error checking  (Jeff Janes <jeff.janes@gmail.com>)
Ответы Re: pg_upgrade --clone error checking  (Jeff Janes <jeff.janes@gmail.com>)
Список pgsql-hackers
On 2019-May-02, Jeff Janes wrote:

> I think the error message wording is OK, I think it should be thrown
> earlier, before the "Creating dump of database schemas" (which can take a
> long time), and preferably before either database is even started.  So
> ideally it would be something like:
> 
> 
> Performing Consistency Checks
> -----------------------------
> Checking cluster versions
> Checking file cloning support
> File cloning not supported on this platform
> Failure, exiting
> 
> 
> When something is doomed to fail, we should report the failure as early as
> feasibly detectable.

I agree -- this check should be done before checking the database
contents.  Maybe even before "Checking cluster versions".

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jeff Janes
Дата:
Сообщение: Re: pg_upgrade --clone error checking
Следующее
От: Fabien COELHO
Дата:
Сообщение: Re: pgbench - add option to show actual builtin script code