Haven't read the patch, but I tried applying it on top of my tablespace
fixing patch ... and my first report is that this query in regress fails
(three times):
select conname, obj_description(oid, 'pg_constraint') from pg_constraint where conname = 'c_chk' order by 1, 2;
conname | obj_description
---------+---------------------------------------
+ c_chk | alttype_cleanup_idx check constraint
c_chk | alttype_cleanup_idx1 check constraint
c_chk | alttype_cleanup_idx2 check constraint
- c_chk | alttype_cleanup_idx check constraint
(3 rows)
I think you should use 'ORDER BY 2 COLLATE "C"' to avoid the problem.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services