Re: Cleanup/remove/update references to OID column

Hi,

On 2019-04-17 19:42:19 -0500, Justin Pryzby wrote:
> diff --git a/doc/src/sgml/information_schema.sgml b/doc/src/sgml/information_schema.sgml
> index 234a3bb..9c618b1 100644
> --- a/doc/src/sgml/information_schema.sgml
> +++ b/doc/src/sgml/information_schema.sgml
> @@ -1312,8 +1312,8 @@
>    
>     The view columns contains information about all
>     table columns (or view columns) in the database.  System columns
> -   (ctid, etc.) are not included.  Only those columns are
> -   shown that the current user has access to (by way of being the
> +   (ctid, etc.) are not included.  The only columns shown
> +   are those to which the current user has access (by way of being the
>     owner or having some privilege).
>    

I don't see the point of this change? Nor what it has to do with oids?


> diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml
> index 189ce2a..f995a76 100644
> --- a/doc/src/sgml/ref/insert.sgml
> +++ b/doc/src/sgml/ref/insert.sgml
> @@ -554,7 +554,7 @@ INSERT oid count     The count is the number of
>     rows inserted or updated.  oid is always 0 (it
>     used to be the OID assigned to the inserted row if
> -   rows was exactly one and the target table was
> +   count was exactly one and the target table was
>     declared WITH OIDS and 0 otherwise, but creating a table
>     WITH OIDS is not supported anymore).
>    

The rows reference is from your change
:(. I'll fold it into another upcoming change for other tableam comment
improvements (by Heikki).

Greetings,

Andres Freund