Re: renaming ExecStoreWhateverTuple

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: renaming ExecStoreWhateverTuple
Дата
Msg-id 20190325163656.d3jcw45gg4sk7ypn@alap3.anarazel.de
обсуждение исходный текст
Ответ на Re: renaming ExecStoreWhateverTuple  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: renaming ExecStoreWhateverTuple
Список pgsql-hackers
Hi,

On 2019-03-25 12:33:38 -0400, Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > Maybe we don't really need the word "tuple".  Like we could just make
> > it slot_store_heap() or SlotStoreHeap().  A slot can only store a
> > tuple, after all.
> 
> I don't think it's wise to think of these things as just "slots";
> that name is way too generic.  They are "tuple slots", and so that
> word has to stay in the relevant function names.

Hm. But we already have slot_{getsomeattrs, getallattrs, attisnull,
getattr, getsysattr}. But perhaps the att in there is enough addiitional
information?

Although now I'm looking at consistency annoyed at slot_attisnull (no r)
and slot_getattr (r) ;)

Greetings,

Andres Freund


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: renaming ExecStoreWhateverTuple
Следующее
От: Tom Lane
Дата:
Сообщение: Re: renaming ExecStoreWhateverTuple