Re: pgsql: pg_regress: Don't use absolute paths for the diff

Поиск
Список
Период
Сортировка
От Stephen Frost
Тема Re: pgsql: pg_regress: Don't use absolute paths for the diff
Дата
Msg-id 20190223003936.GF6197@tamriel.snowman.net
обсуждение исходный текст
Ответ на Re: pgsql: pg_regress: Don't use absolute paths for the diff  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: pgsql: pg_regress: Don't use absolute paths for the diff
Список pgsql-committers
Greetings,

* Michael Paquier (michael@paquier.xyz) wrote:
> On Fri, Feb 22, 2019 at 03:26:35PM -0800, Andres Freund wrote:
> > that's useless, because I can't trivially copy the result file into the
> > expected file anymore. I have to figure out where in the tree it
> > is. Which isn't exactly predictable, between the different tests we
> > have as they locate their test results in different places.
>
> I haven't paid much attention to this commit, but the new behavior is
> likely something which will become annoying in some not-so-far future
> for me as well.
>
> > This is a bad idea.
>
> +1.

Yeah, same here, if I can't easily copy the result file into the
expected file, I'm going to be *most* annoyed...

Thanks!

Stephen

Вложения

В списке pgsql-committers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: pgsql: Fix incorrect function reference in comment of twophase.c
Следующее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: Revert "pg_regress: Don't use absolute paths for the diff"