Re: Too rigorous assert in reorderbuffer.c

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Too rigorous assert in reorderbuffer.c
Дата
Msg-id 20190211185003.GA27084@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: Too rigorous assert in reorderbuffer.c  (Arseny Sher <a.sher@postgrespro.ru>)
Ответы Re: Too rigorous assert in reorderbuffer.c  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Список pgsql-hackers
On 2019-Feb-07, Arseny Sher wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:

> > Ah, okay.  Does the test still fail when run without the code fix?
> 
> Yes. The problem here is overriding cmax of catalog (pg_attribute in the
> test) tuples, so it fails without any data at all.

Makes sense.

I thought the blanket removal of the assert() was excessive, and we can
relax it instead; what do you think of the attached?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Lætitia Avrot
Дата:
Сообщение: Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: PG_RE_THROW is mandatory (was Re: jsonpath)