On Sat, Feb 02, 2019 at 03:38:22AM -0500, Noah Misch wrote:
> The main consequence is the false alarm. A prudent DBA will want to react to
> true wraparound, but no such wraparound has occurred. Also, we temporarily
> waste disk space in pg_xact. This feels like a recipe for future bugs. The
> fix I have in mind, attached, is to change instances of
> ctl->PagePrecedes(FIRST_PAGE_OF_SEGMENT, ROUNDED_cutoffPage) to
> ctl->PagePrecedes(LAST_PAGE_OF_SEGMENT, cutoffPage). I'm inclined not to
> back-patch this; does anyone favor back-patching?
To avoid wasting more of anyone's time: that patch is bad; I'll update this
thread when I have something better.