Re: minor fix in CancelVirtualTransaction

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: minor fix in CancelVirtualTransaction
Дата
Msg-id 20190203102611.grpryp3ve5vvrlcj@alap3.anarazel.de
обсуждение исходный текст
Ответ на Re: minor fix in CancelVirtualTransaction  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Список pgsql-hackers
Hi,

On 2019-01-11 18:35:13 -0300, Alvaro Herrera wrote:
> On 2019-Jan-04, Peter Eisentraut wrote:
> 
> > Your reasoning seems correct to me.
> > 
> > Maybe add a code comment along the lines of "once we have found the
> > right ... we don't need to check the remaining ...".
> > 
> > Or, you can make this even more clear by comparing the backendId
> > directly with the proc entry:
> 
> I did both (the second idea was a non-obvious very nice cleanup --
> thanks).  Patch attached.
> 
> However, now I realize that this code is not covered at all, so I'll put
> this patch to sleep until I write some test for it.

Given that the CF entry has been waiting on this update I'll mark this
as returned with feedback, rather than moving to the next CF.

Greetings,

Andres Freund


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Undo logs
Следующее
От: Andres Freund
Дата:
Сообщение: Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTERCONSTRAINT