On 2019-Jan-18, Amit Langote wrote:
> OK, I agree. I have updated the patch to make things work that way.
Thanks, this is better. There were a few other things I didn't like, so
I updated it. Mostly, two things:
1. I didn't like a seqscan on pg_trigger, so I turned that into an
indexed scan on the constraint OID, and then the other two conditions
are checked in the returned tuples. Also, what's the point on
duplicating code and checking how many you deleted? Just delete them
all.
2. I didn't like the ABI break, and it wasn't necessary: you can just
call createForeignKeyActionTriggers directly. That's much simpler.
I also added tests. While running them, I noticed that my previous
commit was broken in terms of relcache invalidation. I don't really
know if this is a new problem with that commit, or an existing one. The
fix is 0001.
Haven't got around to your 0002 yet.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services